search

qorelanguage / qore

Qore Programming Language
GNU General Public License v2.0
61 stars 10 forks source link

qore build breaks with newer ssl due to missing EVP_sha #22

Closed niclasr closed 9 years ago

niclasr commented 9 years ago

The EVP_sha function is missing in newer versions of openssl. man pages: future, current release This breaks builds of qore. build log Fixes for this might be to remove it or add a configure test to see if EVP_sha is available and only use it if the test succeeds (similar to what is done with the sha512 function). How do you think it should be solved?

davidnich commented 9 years ago

I guess make a test for it and conditionally compile it. In this case there should also be a HAVE_ constant for it as well I think - I have to check how that works tomorrow

I would like to switch to cmake, and I appreciate your efforts there very much btw

If you want to do out in cmake then I'll try to cover it tomorrow in autotools

Thx David On Sep 23, 2015 21:11, "Niclas Rosenvik" notifications@github.com wrote:

The EVP_sha function is missing in newer versions of openssl. man pages: future https://www.openssl.org/docs/manmaster/crypto/EVP_DigestInit.html, current release https://www.openssl.org/docs/man1.0.2/crypto/EVP_DigestInit.html This breaks builds of qore. build log http://pkgsrc.geeklan.co.uk/reports/current/OpenBSD-current/20150919.1053/qore-0.8.11nb2/build.log Fixes for this might be to remove it or add a configure test to see if EVP_sha is available and only use it if the test succeeds (similar to what is done with the sha512 function). How do you think it should be solved?

— Reply to this email directly or view it on GitHub https://github.com/qorelanguage/qore/issues/22.

niclasr commented 9 years ago

The cmake stuff needed is only check_cxx_symbol_exists(EVP_sha openssl/evp.h HAVE_OPENSSL_SHA) . I can try to fix the source code changes and autotools stuff tomorrow if you don't want to waste your time on it.

davidnich commented 9 years ago

That would be great, thanks niclas On Sep 23, 2015 21:40, "Niclas Rosenvik" notifications@github.com wrote:

The cmake stuff needed is only check_cxx_symbol_exists(EVP_sha openssl/evp.h HAVE_OPENSSL_SHA) . I can try to fix the source code changes and autotools stuff tomorrow if you don't want to waste your time on it.

— Reply to this email directly or view it on GitHub https://github.com/qorelanguage/qore/issues/22#issuecomment-142707247.

niclasr commented 9 years ago

Fixed in fc181070ad1afbf49af2e8fc968b97328d690a86 Closing.