search

qos-ch / logback

The reliable, generic, fast and flexible logging framework for Java.
http://logback.qos.ch
Other
2.97k stars 1.28k forks source link

fixes #803 PatternLayoutBase custom converter classloading in OSGi #804

Open enapps-enorman opened 4 months ago

enapps-enorman commented 4 months ago

This is the proposed changes to resolve issue #803

This is an alternate way to declare the PatternLayoutBase defaultConverterMap and instanceConverterMap values in a way that works with the OSGi classloading restrictions.

These changes should preserve backward compatibility with code that defines the converter map using the original technique

I also updated the tests in an attempt to confirm it works as expected.

Please review and merge if you agree with the proposed changes.

enapps-enorman commented 3 months ago

Hi @ceki

We would appreciate a review of this proposal if you (or someone else) has the time. Knowing if this proposal will be accepted or not will help us decide how to move forward.

Thanks

enapps-enorman commented 5 days ago

Hi @ceki

Checking back in again since we haven't gotten any feedback on the PR since it was proposed 4 months ago.

enapps-enorman commented 5 days ago

re-opened... sorry I hit the wrong button and accidentally closed it.