Closed johanmast closed 4 months ago
We also recognized broken logging configurations after upgrading logback from 1.5.4 to 1.5.5.
In our case there are <springProperty>
tags in an included Snippet that are not handled correctly anymore.
Version 1.5.5 migrated IncludeAction
to IncludeModelHandler
(af92be47a940393e11decab0a7ee4cb802d2b5e8) , which seems to break something.
@fupgang File inclusion code moved from IncludeAction
to IncludeModelHandler
. This changes the moment in time file inclusion occurs.
<springProperty>
might rely on some logback internals in IncludeAction
which have changed. This a different issue than what @johanmast reports above.
@fupgang Please create a separate issue.
@johanmast I will add a test case for the situation you describe which is a very special case, i.e a conditional within an inclusion...
I am correct to assume that you are also using logback-core 1.5.5?
Hi @ceki,
Thank you. Yes, dependencies used are:
Created https://jira.qos.ch/browse/LOGBACK-1768 for tracking.
Fixed in commit 759fc25ee38435
logback version 1.5.6 was released earlier today.
Thank you @ceki, I can confirm that it works again when using version 1.5.6
After updating to logback-classic 1.5.5, conditional
logger
elements from included files break.The conditional
logger
is ignored and the following line is logged:Reproduction
logback.xml:
logback-include.xml:
Expected behaviour:
Actual behaviour:
The expected behaviour still works with version 1.5.4.