search

qos-ch / reload4j

reload4j is a drop-in replacement for log4j 1.2.17
Apache License 2.0
148 stars 22 forks source link

CRLF in Many Files #40

Open wirelessben opened 2 years ago

wirelessben commented 2 years ago

I'm trying to build a matching binary for reload4j-1.2.19.jar, but there are CRLFs in the following files: 11568 02-08-2022 08:07 META-INF/LICENSE 164 02-08-2022 08:07 META-INF/NOTICE 1462 02-08-2022 08:07 org/apache/log4j/lf5/config/defaultconfig.properties 7265 02-08-2022 08:07 org/apache/log4j/xml/log4j.dtd 16175 02-08-2022 08:07 META-INF/maven/ch.qos.reload4j/reload4j/pom.xml 62 02-08-2022 08:07 META-INF/maven/ch.qos.reload4j/reload4j/pom.properties

Building on a Mac with Java 8, I just get regular LFs, thus causing the diffs. I did switch to branch 982b7205b933f99556091d3e345ad31b124b55df before building with Maven 3.8.4. reload4j git:(982b7205) ✗ mvn --version Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537) Maven home: /usr/local/Cellar/maven/3.8.4/libexec Java version: 1.8.0_301, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk1.8.0_301.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "10.16", arch: "x86_64", family: "mac"

ceki commented 2 years ago

Thank you for the heads up. I'll have a look at these CRLF issues.

ceki commented 2 years ago

When built in different environments, I see trailing white space issue in some files. More importantly, I see differences in some class files as well.

wirelessben commented 2 years ago

Yes, I also saw the differences in these two class files:

org/apache/log4j/jdbc/JDBCAppender.class org/apache/log4j/xml/DOMConfigurator$2.class