Fix text formatting in slf4j-jdk-platform-logging to use the correct JDK convention

qos-ch / slf4j

Simple Logging Facade for Java

http://www.slf4j.org

MIT License

2.35k stars 990 forks source link

Fix text formatting in slf4j-jdk-platform-logging to use the correct JDK convention #351

Closed Mechite closed 1 year ago

Mechite commented 1 year ago

While there is a comment here showing that it was understood the JDK has a different convention, the wrong format method was used here. The JDK uses MessageFormat.

I have not tested this PR and cannot assure that I have made the correct change, a reviewer should test this fork and see if invoking the system logger with extra parameters, i.e. log("Hello, {0}!", "world") outputs correctly.

Mechite commented 1 year ago

Alright, so after further review of my own PR

I didn't sign this off with DCO as I missed out the contribution instructions in the README - if this is denied I'll go and make a Jira ticket for it etc
The test suite will likely fail because it is using the wrong formatting convention as well!

Mechite commented 1 year ago

This is a duplicate of https://github.com/qos-ch/slf4j/pull/273, so it is being closed. The diff of the other one is completely identical.