search

qos-ch / slf4j

Simple Logging Facade for Java
http://www.slf4j.org
MIT License
2.32k stars 980 forks source link

Fluent logging of primitive types #375

Open Webbot99 opened 9 months ago

Webbot99 commented 9 months ago

When using LoggingEventBuilder to addArgument or addKeyValue the only parameter options are Object or Supplier. If I use any primitive type (boolean, char, byte, short, int, long, float, double) then the compiler autoboxes them, even when the specified log level is not enabled and the Nop builder then discards them. This can generate a lot of eden garbage. This is an issue for me as I am working on a high throughput, garbage free, app which deals primarily in primitive types. Adding these variants as additional methods eg addKeyValue("Foo", 1.23d) etc would delay the auto boxing until when, and only when, the logging is going to output something. Currently the only surefire way to avoid this is to wrap such logging within an is<Level>Enabled block.

Webbot99 commented 9 months ago

Related to #367 Which suggests using a Supplier of the primitive type does not help

ceki commented 8 months ago

@Webbot99 Thank you for this report. SLF4J 2.1.0-alpha0 to be released within the next few days will add default arg(boolean), arg(byte), arg(short)... methods to the LoggingEventBuilder interface with NOP implementations in NOPLoggingEventBuilder.

See the changes to LoggingEventBuilder in commit 154b4e4afa6b2 for details.

ceki commented 8 months ago

See the changes to LoggingEventBuilder in commit 154b4e4afa6b2 for details.