search

qossmic / deprecation-detector

MIT License
391 stars 40 forks source link

Include vendor deprecation warnings #124

Open arderyp opened 7 years ago

arderyp commented 7 years ago

Firstly, thanks for the awesome tool!

I've run it against my codebase with:

./deprecation-detector check $PROJECT/src $PROJECT/vendor

It found lots of helpful things to cleanup. Now when I run it, nothing is found. However, if I go to one of my views, I do see deprecation warnings in the profiler related to my Twig dependency. It's not my issue, but the related deprecation is discussed here: https://github.com/twigphp/Twig/issues/2267

If there is any more info I can provide that would be helpful, please let me know.

slde-robin commented 7 years ago

Actually the tool doesn't check if there are any deprecations in your twig templates.

arderyp commented 7 years ago

Right, that's the reason I opened the issue, so there could be some discussion about it.

Do you think this type of functionality could be added? I'm thinking beyond templates specifically. Do you think the tool could find and report all deprecation warnings that the symfony profiler would report? That would be the ultimate goal, I think.

Sent from a phone

On Feb 28, 2017, at 12:24 AM, slde-robin notifications@github.com wrote:

Actually the tool doesn't check if there are any deprecations in your twig templates.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

slde-robin commented 7 years ago

The profiler gathers the warnings by actually executing the code. The detector does not execute the code.

To add Twig support we would need a twig parser and so on... IMO thats too much.

But you could check your compiled Twig templates in the cache dir for deprecations. Right now I don't have the time to test that myself. It would be great if you could test that and give me review

arderyp commented 7 years ago

Awesome, thanks for the very helpful info.

Sent from a phone

On Mar 1, 2017, at 5:25 AM, slde-robin notifications@github.com wrote:

The profiler gathers the warnings by actually executing the code. The detector does not execute the code.

To add Twig support we would need a twig parser and so on... IMO thats too much.

But you could check your compiled Twig templates in the cache dir for deprecations. Right now I don't have the time to test that myself.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.