qossmic / deprecation-detector

MIT License
390 stars 40 forks source link

Add Blacklist for deprecations #7

Open slde-robin opened 8 years ago

slde-robin commented 8 years ago

If your project uses a deprecation heavily your whole output is full of it. We should add a configuration to blacklist some deprecations.

umulmrum commented 8 years ago

It might also be useful to be able to exclude certain files or directories.

chr-hertel commented 8 years ago

i agree on excluding certain files or directories, but i'm not sure about a deprecation blacklist. I don't like the idea of extensive option usage like #17 provides as solution. maybe a blacklist by config file? a config file would make it easy to exclude files and directories as well.

bestform commented 8 years ago

The implementation in #17 provides an option to implement a file/folder exclude as well. How you define the filter options can be decided for every filter separately. I think, the option to exclude certain calls is suited for being configured on the command line, but I am open for discussion on that matter. The reason I think this is a good option is that the normal use case will probably be:

Adding such filter to a config file wouldn't be a convenient way to go, and moreover would probably encourage ignoring certain errors by default and forgetting about it.

MarvinKlemp commented 8 years ago

after #17 we still need the implementation for other violations. May we should also add an output if a specific deprecation is filtered.

bestform commented 8 years ago

Adding active filters to the output is a good idea.

MarvinKlemp commented 8 years ago

@bestform do you want to add the missing filters ?

bestform commented 8 years ago

@MarvinKlemp what do you mean exactly? The filters itself (if so: is there a list of missing filters?) or the information about active filters in the output?

MarvinKlemp commented 8 years ago

if you want both :laughing: But IMO we should wait until #45 is merged