Bump PHP Parser version to support PHP 8.3

qossmic / deptrac

Keep your architecture clean.

https://qossmic.github.io/deptrac

MIT License

2.6k stars 135 forks source link

Closed benr77 closed 7 months ago

benr77 commented 8 months ago

This PR addresses problems parsing PHP 8.3 syntax, by bumping the version of php-parser to the latest patch release.

There continue to be deprecation warnings from phpdocumentor/graphviz but this project appears to be abandoned.

Other than that this is working for me perfectly on my project recently upgraded to PHP 8.3.

Resolves #1341

benr77 commented 8 months ago

Sorry yes I just saw the failed builds. Lock file is now updated but "Composer Diff" check is failing still - what's that about?

benr77 commented 8 months ago

Also, we should add PHP 8.3 to the CI but I guess not in this PR.

xabbuh commented 8 months ago

@benr77 Not sure where that is coming from but I don't think it's related to your patch.

patrickkusebauch commented 8 months ago

The composer Diff check always fails if the PR is coming from a fork and you are changing the composer file. Nothing to worry about.

gennadigennadigennadi commented 7 months ago

@benr77 thank you very much for this PR!

kunicmarko20 commented 6 months ago

Is there any chance we can get a release with this change?