search

qouteall / ImmersivePortalsModForForge

Apache License 2.0
53 stars 21 forks source link

Fix a bug related to attributes on players. #182

Closed DylanJones closed 3 years ago

DylanJones commented 3 years ago

This mixin is used when running under Fabric to add a custom attribute to players to tweak the reach distance. However, it isn't needed under forge and causes an issue where other mods' custom attributes don't get added to new players properly. I just added a check so that it doesn't run under Forge which seems to fix the issue, at least with Botania.

qouteall commented 3 years ago

Thanks for the research. My workflow is to develop the Fabric version and remap to the Forge version. So the pr that touches the common code should be in the Fabric version. I am going to apply that by myself.

qouteall commented 3 years ago

There is a preview release to test it https://github.com/qouteall/ImmersivePortalsModForForge/releases/tag/v0.10-1.16

Neubulae commented 3 years ago

This caused issues on fabric too. Same problem, pixie spawn chance not found.