search

qouteall / ImmersivePortalsModForForge

Apache License 2.0
53 stars 21 forks source link

[forge] [1.16.5] incompatibility with RFTDim #233

Open Bass2style opened 3 years ago

Bass2style commented 3 years ago

Hi,

when joigning a brand new rftdim dimension, the server crashes. this is happening on both single and multiplayer "servers".

idk who is creating issues, but i reported the bug on rftdims GIT here : https://github.com/McJtyMods/RFToolsDimensions/issues/342

the crashlogs are pinned on the RFTDim report, but here are the same i posted on their GIT : crashlog from my single player crash : https://gist.github.com/Bass2style/4fa447c14ad7f94bdb99d93f3df5d56c this from our server : https://gist.github.com/Bass2style/3225aacfb64a94f8addcf870c689345b

actual versions used : Minecraft: 1.16.5 Forge: 36.0.58 McJtyLib: 5.0.19 RFTools: 2.0.10 RFTools Dimensions: 7.0.6 beta ImmersivePortals : 0.16

Razboy20 commented 3 years ago

I'm just looking at the crash log, and it seems to be some issue with RFTools itself rather than immersive portals.

Missing Dimension ResourceKey ...

The crash log mentions that the rftools dimension is missing a key, eg. making it difficult to distinguish from others.

I haven't contributed to Immersive Portals or RFTools, (or have worked with MC Mods), so I may be wrong, but seems like something for the rftools developer to look into.

Bass2style commented 3 years ago

well, there is a clear conflict between the two mods, ImmersivePortals is listed on lines 8/9/10/18/22/28/29/30/32/33 and 35, and when IP is removed from the modpack, everything is working without issue, maybe it's IP that is not working great with RFTDim, or it's RFTDim that's doing something weird with ImmersivePortals, but, bot in a same pack are crashing when joining a rftdim dimension, so i reported the crash on both GIT, because it's too difficult for me to find out wich one is causing troubles.

i'm only a player, who find bugs when playing, and reporting them to the mod authors, i'm not a dev. ^^

Razboy20 commented 3 years ago

Well, the issue is that Immersiveporals is trying to access some data property of the rftools dimensions, but rftools doesn't set it, and as such, breaks. This may also just be an issue of Forge being not supported well for Immersive Portals, as it is meant for fabric.

Bass2style commented 3 years ago

i'm not sur wich difference are between the Forge and Fabric version of ImmersivePortals, but it's possible that IP use methods not that supported by Forge, wait and see. i like both mods, and i don't want to remove one of the two to get those working well, so i'm now waiting to see if a fix should come out. :D i did my job by reporting it.

defsil commented 3 years ago

Same! Actually, while IP does crash Minecraft immediately on entering a brand new RFTools dimension, you can enter it without problem after the restart. It's still quite a nasty bug, considering it's practically a crash-on-will thing for servers, but at least you can still explore the world more-or-less painlessly in singleplayer. :3

VirtualGaming1 commented 3 years ago

Well I have IP for a while in the modpack and I would like a mod that make custom dim like RFTools Dim but look like can't. Do wish this get fix soon.

VirtualGaming1 commented 3 years ago

this is also the same issue as #223 as well so this have been a problem but no comment from any devs as well. wish they comment at least that they know this issue.

McJty commented 3 years ago

The thing is that RFTools Dimensions generates dimensions dynamically. i.e. it's like Mystcraft where it gives players the option to generate dimensions in game. I think Immersive Portals doesn't cope with that well. I don't think there is anything from my side that I can do to solve this