search

qouteall / ImmersivePortalsModForForge

Apache License 2.0
53 stars 21 forks source link

Incompatibility with Mixin 0.8.3 #284

Open thejudge156 opened 3 years ago

thejudge156 commented 3 years ago

I was working on a development environment with immersive portals and the latest Mixin, 0.8.3, for a mod I am working on that uses immersive portals as a dependency. 0.8.2 works fine, but when using 0.8.3 it crashes on startup, logs are attached. latest.log

piousminion commented 3 years ago

This is affecting me as well. I know you dislike Forge over Fabric, but many of us are stuck. If all, or even "some" of, the other mods I wanted to play used fabric, that would be nice, but until then I'm stuck using Forge.

I've got my fingers crossed that you'll fix this.

ConnorTron110 commented 2 years ago

Been testing this a bit and by looking at the error itself, it seems to be an issue with the injection itself so a 'static' method is being converted to a non-static, which mixin freaks out about since it shouldn't do that. This doesn't seem to be a mixin issue itself as I've tested Forge 1.16.5-36.2.5 which updates mixin to 0.8.4 and its the same issue.

My testing resulted in some interesting results.

First I tried with the latest forge version (36.2.5) and I ran into an immediate crash (with optifine) I then tried decreasing my forge version by 1 and I kept crashing up to 36.2.0 (with optifine) After that I tried using 36.1.66 and it worked (no optifine) If then done the opposite and started going back up the versions and every version worked excluding 36.2.5 (no optifine)

Here are the versions I was working with for this test Optifine Version Immersive Portals Ver
HD_U_G8 0.16

So I'm not too sure if this is a mixin issue anymore but rather an optifine issue, excluding 36.2.5 it's a mixture of everything!

The best fix you can do temporarily if you still want to use Immersive portals is to not use optifine, and use Forge-1.16.5-36.2.4 ✔

EDIT: Apparently Optifine G7 works, haven't tested this however it is worth a shot.

piousminion commented 2 years ago

So I'm not too sure if this is a mixin issue anymore but rather an optifine issue, excluding 36.2.5 it's a mixture of everything!

I'm trying to start a server, which doesn't and wouldn't use optifine. :P mixin errors galore. :/