search

qouteall / ImmersivePortalsModForForge

Apache License 2.0
53 stars 21 forks source link

Incomp with JM #285

Open cd-FileX opened 3 years ago

cd-FileX commented 3 years ago

Well, I know this isn't supported and you won't fix it, but here is a copy of all stuff from JourneyMap issues:

JourneyMap Version: 5.7.3

Forge Version: 36.1.65

Minecraft Version: 1.16.5

Describe the problem in repeatable steps:

  1. Use JourneyMap + Immersive Portals
  2. Travel through a Immersive Portal supported Portal
  3. See the result on the map (in attachment) (4. The glitched stuff also randomly (partly) disappears on the map or/and some darkened spots appear) 2021-07-27_16 58 18 2021-07-27_16 44 03 | Cave Mapping / "Show Caves" is disabled 2021-07-27_16 48 57 2021-07-27_16 53 54 (I got about 90 Mods loaded but travelling between worlds that support Immersive Portals causes this) It also seems like this is not always appearing, just randomly

New Example with more detailed and only JM and ImmP:

  1. Install JM and ImmP newest Version
  2. Build for this example a Nether Portal and activate it
  3. Go through it (and maybe look shortly in not a too long distance around)
  4. Go back through the portal (if it's important through the side you came out)
  5. See the result on the Map (my try in attachment) (this time not such an extreme result but you can see what I mean I hope) 2021-07-27_17 41 36

Answer from JM Dev:

Looking at what is happening, it does not seem to be on jourenymap side of things. Immersive Portals is doing something that is messing up how we read the chunks. I have not isolated it yet. Immersive portals seems kind of buggy in general.

https://github.com/qouteall/ImmersivePortalsModForForge/blob/11f4665ac1a56a01d5049aedcccdb45bd9abc7e8/src/main/java/com/qouteall/immersive_portals/chunk_loading/MyClientChunkManager.java#L130 likely a bug here between line 130 and 160. We check the chunk light level and color it based on what that light level is. We do not control it, only show what the chunk tells us. I did notice chunk light levels changing for the odd looking chunks. Feel free to reference this issue on their issue tracker.