Closed pihentagy closed 4 years ago
pbek
commented
4 years ago There are options for markdown-it you could add, maybe there is one. For the possible configuration options check: https://github.com/markdown-it/markdown-it/tree/master/lib/presets
I guess you could also strip comment tags out yourself in the script. Pull requests are welcome.
pbek
commented
4 years ago Mentioning the other developers of scripts (see issue template) is also always a good idea. :grin:
bessw
commented
4 years ago You can change this behavior in the scripts settings under the section Markdown-it options
by changing //html = false to html = true.
This enables parsing of HTML tags in the source.
pihentagy
commented
4 years ago Thanks for the info. So it also enables html comments.
Expected behaviour
html comments are not shown
Actual behaviour
Comments are shown.
Steps to reproduce
Create a new markdown note (markdown-it plugin on)
and you will see
<!-- you should not see this -->in the preview.Relevant log output in the Log panel
Expand
``` [13:58:09] [debug] updatePanelMenu - 'updatePanelMenu' [13:58:09] [debug] on_noteTreeWidget_currentItemChanged [13:58:09] [debug] setCurrentNote - 'note': Note:Information about the application, settings and environment
Expand
QOwnNotes Debug Information =========================== ## General Info **Current Date**: `Mon Mar 2 14:19:16 2020` **Version**: `20.3.0` **Build date**: `Feb 29 2020` **Build number**: `679` **Platform**: `linux` **Operating System**: `Linux Mint 19.3` **Build architecture**: `x86_64` **Current architecture**: `x86_64` **Release**: `Launchpad PPA` **Qt Version (build)**: `5.9.5` **Qt Version (runtime)**: `5.9.5` **Portable mode**: `no` **Settings path / key**: `/home/pihentagy/.config/PBE/QOwnNotes.conf` **Application database path**: `/home/pihentagy/.local/share/PBE/QOwnNotes/QOwnNotes.sqlite` **Application arguments**: `/usr/bin/QOwnNotes` **Qt Debug**: `0` **Locale (system)**: `en_US` **Locale (interface)**: *empty* **Primary screen resolution**: `1920x1080` **Screen resolution(s)**: `1920x1080, 1920x1080` **Icon theme**: `Mint-Y` **Notes in current note folder**: `37` **Calendar items**: `0` **Enabled scripts**: `6` ## Server Info **serverUrl**: *empty* **appIsValid**: `no` **notesPathExists**: *empty* **connectionErrorMessage**: *empty* ## Spellchecking **Enabled**: `true` **Selected language**: `auto` **Language codes**: `de_AT, de_AT_frami, de_CH, de_CH_frami, de_DE, de_DE_frami, en_AU, en_CA, en_GB, en_US, en_ZA, es_AR, es_BO, es_CL, es_CO, es_CR, es_CU, es_DO, es_EC, es_ES, es_GT, es_HN, es_MX, es_NI, es_PA, es_PE, es_PR, es_PY, es_SV, es_US, es_UY, es_VE, fr, fr_BE, fr_CA, fr_CH, fr_FR, fr_LU, fr_MC, it_CH, it_IT, pt_BR, pt_PT, ru_RU` **Language names**: `Österreichisches Deutsch (Österreich), Österreichisches Deutsch (Österreich), Schweizer Hochdeutsch (Schweiz), Schweizer Hochdeutsch (Schweiz), Deutsch (Deutschland), Deutsch (Deutschland), Australian English (Australia), Canadian English (Canada), British English (United Kingdom), American English (United States), English (South Africa), español (Argentina), español (Bolivia), español (Chile), español (Colombia), español (Costa Rica), español (Cuba), español (República Dominicana), español (Ecuador), español de España (España), español (Guatemala), español (Honduras), español de México (México), español (Nicaragua), español (Panamá), español (Perú), español (Puerto Rico), español (Paraguay), español (El Salvador), español (Estados Unidos), español (Uruguay), español (Venezuela), français, français (Belgique), français canadien (Canada), français suisse (Suisse), français (France), français (Luxembourg), français (Monaco), italiano (Svizzera), italiano (Italia), português do Brasil (Brasil), português europeu (Portugal), русский (Россия)` **Application dictionaries path**: `/home/pihentagy/.local/share/PBE/QOwnNotes/dicts` ## Note folders **currentNoteFolderId**: `1` ### Note folder `default` **id**: `1` **isCurrent**: `yes` **activeTagId**: `-1` **localPath**: `/home/pihentagy/Notes` **remotePath**: `Notes` **cloudConnectionId**: `1` **isShowSubfolders**: `yes` **isUseGit**: `yes` **activeNoteSubFolder name**: `developer-documentation` **database file**: `/home/pihentagy/Notes/notes.sqlite` ## Cloud connections ### Cloud connection `Default` **id**: `1` **isCurrent**: `yes` **serverUrl**: *empty* **username**: *empty* ## Enabled scripts ### Script `Epsilon Notes compatible tags (YAML tags)` **id**: `1` **path**: `/home/pihentagy/.local/share/PBE/QOwnNotes/scripts/epsilon-notes-tags/epsilon-notes-tags.qml` **variablesJson**: *empty* **identifier**: `epsilon-notes-tags` **version**: `0.0.2` **minAppVersion**: `18.03.7` ### Script `Unique note id` **id**: `2` **path**: `/home/pihentagy/.local/share/PBE/QOwnNotes/scripts/unique-note-id/unique-note-id.qml` **variablesJson**: *empty* **identifier**: `unique-note-id` **version**: `1.0.1` **minAppVersion**: `18.05.1` ### Script `Markdown-it markdown parser` **id**: `5` **path**: `/home/pihentagy/.local/share/PBE/QOwnNotes/scripts/markdown-it/markdown-it.qml` **variablesJson**: ``` { "customStylesheet": "", "options": "{\n //html: false, // Enable HTML tags in source\n //xhtmlOut: false, // Use '/' to close single tags ()\n //breaks: false, // Convert '\\n' in paragraphs into
\n //langPrefix: 'language-', // CSS language prefix for fenced blocks\n //linkify: false, // autoconvert URL-like texts to links\n\n // Enable some language-neutral replacements + quotes beautification\n //typographer: false,\n\n // Double + single quotes replacement pairs, when typographer enabled,\n // and smartquotes on. Could be either a String or an Array.\n //\n // For example, you can use '«»„“' for Russian, '„“‚‘' for German,\n // and ['«\\xA0', '\\xA0»', '‹\\xA0', '\\xA0›'] for French (including nbsp).\n //quotes: '\\u201c\\u201d\\u2018\\u2019', /* “”‘’ */\n\n // Highlighter function. Should return escaped HTML,\n // or '' if the source string is not changed and should be escaped externaly.\n // If result starts with
Notify @pbek @bessw @MilanRusev