qpkorr / vim-renamer

Git repo for http://www.vim.org/scripts/script.php?script_id=1721
MIT License
82 stars 11 forks source link

Windows OS ,Fix "[]" in dirname , globPath() did not correctly escape the string . And a small improvement for this handy plugin. #12

Closed onenew closed 5 years ago

onenew commented 5 years ago

In a dir like "[LK][name][VERSION]" vim-renamer just didnot work. This pr fixed it .

I have a map : nmap w :setlocal swf|up! , the 2nd patch makes the map works .

qpkorr commented 5 years ago

Hey - sorry for the slow response. You've got 3 commits there - the first is a bug - thank you very much for finding and fixing it for the potential benefit of everyone. The second two are your preferences, which some will no doubt share, but some no doubt won't. I've merged your bug fix in, but figure the other two commits are best handled as you already have - via a personal fork. That may change in future, but I'll close the request for now until I get more evidence of widespread support. Hope that makes sense - thanks again for the fix.

onenew commented 5 years ago

The second two patches were sent by mistake. I am not very familiar with github. Thank you for your serious work in maintaining this project for a long time.

qpkorr commented 5 years ago

No problem - I'm very much a github novice too - thanks again for your help :)