Client: fix spots* methods options leaking to other methods

qpowell / google_places

A Ruby wrapper around the Google Places API

MIT License

382 stars 188 forks source link

Client: fix spots* methods options leaking to other methods #111

Closed mherold closed 6 years ago

mherold commented 6 years ago

Several methods with options argument had the side effect of changing the Client instance's @options variable. This caused any option used in a call (e.g. to my_client.spots) to also be used in consecutive calls.

edwinwills commented 6 years ago

Sorry just catching up on things and saw this. Thanks so much for your PR - agree that this is a problem. Do you mind knocking together a quick spec so that we make sure we don't regress this behaviour, then should be all good to go.

mherold commented 6 years ago

Thanks for merging so quickly!

A new release would be awesome, too ;-) Thank you!

edwinwills commented 6 years ago

All good - new release up now as well. Cheers!