qpsolvers / qpbenchmark

Benchmark for quadratic programming solvers available in Python
Apache License 2.0
111 stars 10 forks source link

Plot whiskers #52

Closed ottapav closed 1 year ago

ottapav commented 1 year ago

1) When plotting primal_residual, and similarly for dual_residual, the plots have whiskers (see end of the orange line on the plot below). image

2) When typing: python qpsolvers_benchmark\benchmark.py maros_meszaros_dense plot dual_residual high_accuracy --solvers ecos cvxopt scs osqp qpSWIFT the qpSWIFT data are missing due to case sensitivity with no warning. Maybe the data plot could be insensitive to the letter cases. image

stephane-caron commented 1 year ago

I can reproduce the whiskers :cat:

$ ./benchmark.py maros_meszaros_dense plot primal_residual high_accuracy                        

image

stephane-caron commented 1 year ago

After fix: image

stephane-caron commented 1 year ago

As a matter of fact, I think it makes sense to trim solutions that don't respect the tolerance requirement. Follow-up in https://github.com/qpsolvers/qpsolvers_benchmark/pull/54.

stephane-caron commented 1 year ago

@ottapav Whoops, almost missed your second point. Feel free to open separate issues. Let me move it to https://github.com/qpsolvers/qpsolvers_benchmark/issues/55.