qpv-research-group / rayflare

Open-source, integrated optical modelling of complex stacks
Other
33 stars 12 forks source link

Consistent structs #10

Closed phoebe-p closed 3 years ago

phoebe-p commented 3 years ago

Quite major changes in how information is passed to tmm_structure, rt_structure and rcwa_structure. All details such as incidence angles (always in radians), wavelengths (in m) and polarization are now passed through the 'options' dictionary, while only the information necessary to update the structure is required by init(). Also made the use of degrees/radians more consistent.

codecov[bot] commented 3 years ago

Codecov Report

Merging #10 into devel will increase coverage by 2.61%. The diff coverage is 78.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel      #10      +/-   ##
==========================================
+ Coverage   64.64%   67.25%   +2.61%     
==========================================
  Files          19       19              
  Lines        2189     2220      +31     
==========================================
+ Hits         1415     1493      +78     
+ Misses        774      727      -47     
Impacted Files Coverage Δ
rayflare/rigorous_coupled_wave_analysis/rcwa.py 53.41% <43.58%> (+1.19%) :arrow_up:
rayflare/ray_tracing/rt.py 78.09% <70.00%> (+0.17%) :arrow_up:
rayflare/transfer_matrix_method/tmm.py 90.68% <93.67%> (+16.15%) :arrow_up:
rayflare/options.py 100.00% <100.00%> (ø)
rayflare/structure.py 88.09% <100.00%> (-0.28%) :arrow_down:
rayflare/transfer_matrix_method/lookup_table.py 84.61% <100.00%> (+1.51%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 93736fc...32682a6. Read the comment docs.