search

qpv-research-group / rayflare

Open-source, integrated optical modelling of complex stacks
Other
31 stars 11 forks source link

Correct treatment of non-normal incidence angle and n > 1 refractive index in incidence medium #11

Closed phoebe-p closed 3 years ago

phoebe-p commented 3 years ago

Makes the calculation of reflection, transmission, absorption per layer and absorption profiles at non-normal incidence more clear (corrections for the angle and refractive index of the incidence medium now take place inside the relevant functions rather than being applied externally in various places). More tests also added. Confirmation that RCWA and TMM give the same result even for non-normal incidence and n=/=1 in incidence medium.

codecov[bot] commented 3 years ago

Codecov Report

Merging #11 into devel will increase coverage by 0.70%. The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel      #11      +/-   ##
==========================================
+ Coverage   69.63%   70.34%   +0.70%     
==========================================
  Files          19       19              
  Lines        2220     2209      -11     
==========================================
+ Hits         1546     1554       +8     
+ Misses        674      655      -19
Impacted Files Coverage Δ
rayflare/rigorous_coupled_wave_analysis/rcwa.py 64.15% <96.77%> (+1.48%) :arrow_up:
rayflare/transfer_matrix_method/tmm.py 93.18% <0.00%> (+1.43%) :arrow_up:
rayflare/state.py 75.00% <0.00%> (+25.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da0987e...7d4620e. Read the comment docs.