search

qpv-research-group / rayflare

Open-source, integrated optical modelling of complex stacks
Other
31 stars 11 forks source link

Check for valid optical method in Interface #66

Closed benvial closed 4 months ago

benvial commented 4 months ago

This addresses https://github.com/qpv-research-group/rayflare/issues/35, I think it is better to catch this early rather than deferring it when calling process_structure.

Thanks for this great package!

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.18%. Comparing base (74bcef6) to head (9b32f33).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #66 +/- ## ========================================== + Coverage 93.14% 93.18% +0.03% ========================================== Files 20 20 Lines 3033 3036 +3 ========================================== + Hits 2825 2829 +4 + Misses 208 207 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

phoebe-p commented 4 months ago

Thank you! I had a look at your packages a while ago too, very nice, if I ever have time/a pressing research need it would be cool to integrate an interface with gyptis since I don't currently have an FEM implementation.

(Failing tests are unrelated to this PR)