qpv-research-group / solcore5

A multi-scale, python-based library for the modelling of solar cells and semiconductor materials
https://www.solcore.solar/
Other
133 stars 77 forks source link

Register short circuit solver #234

Closed dalonsoa closed 2 years ago

dalonsoa commented 2 years ago

Adds the registry for the short circuit solvers and update docstrings for the short_circuit_pdd function

codecov[bot] commented 2 years ago

Codecov Report

Merging #234 (de18f91) into develop (1f93945) will increase coverage by 0.05%. The diff coverage is 76.62%.

@@             Coverage Diff             @@
##           develop     #234      +/-   ##
===========================================
+ Coverage    46.01%   46.07%   +0.05%     
===========================================
  Files           85       85              
  Lines         9118     9133      +15     
===========================================
+ Hits          4196     4208      +12     
- Misses        4922     4925       +3     
Impacted Files Coverage Δ
solcore/solar_cell_solver.py 70.80% <37.50%> (-0.27%) :arrow_down:
...poisson_drift_diffusion/DriftDiffusionUtilities.py 86.16% <78.16%> (-0.31%) :arrow_down:
solcore/registries.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more