Closed Abelarm closed 1 year ago
Merging #242 (2034eb5) into develop (d5ab3bd) will increase coverage by
10.95%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## develop #242 +/- ##
============================================
+ Coverage 46.15% 57.10% +10.95%
============================================
Files 85 103 +18
Lines 9124 11615 +2491
============================================
+ Hits 4211 6633 +2422
- Misses 4913 4982 +69
Impacted Files | Coverage Δ | |
---|---|---|
solcore/tests/test_light_source.py | 100.00% <0.00%> (ø) |
|
solcore/tests/test_dielectric_constant.py | 100.00% <0.00%> (ø) |
|
solcore/tests/test_tmm_core_vec.py | 100.00% <0.00%> (ø) |
|
solcore/tests/test_solar_cell_solver.py | 100.00% <0.00%> (ø) |
|
solcore/tests/test_registries.py | 89.70% <0.00%> (ø) |
|
solcore/tests/test_structure.py | 100.00% <0.00%> (ø) |
|
solcore/tests/conftest.py | 92.66% <0.00%> (ø) |
|
solcore/tests/test_optics.py | 100.00% <0.00%> (ø) |
|
solcore/tests/mock_ddModel.py | 100.00% <0.00%> (ø) |
|
solcore/tests/test_state.py | 100.00% <0.00%> (ø) |
|
... and 13 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Hi both, sorry I missed the review request for this PR. I will quickly check tomorrow when I have my Windows laptop if the Windows wheel also works and then merge!
Edit: it works :) this is great!!!
This PR refer to the issue #238 ad it changes the build system from
numpy.distutils
tomeson
.command to build:
with_pdd=true
: if to build thepdd
install_test=true
: if to copy the test directoryMajor changes:
poisson_drift_diffusion
fortran codesetup.py
moving topyproject.toml
devpy
as a support build toolmac-os arm64
now available through cross-compiling with the support ofpdd
cibuildwheel
for the whole build process (common to all architectures)Minor changes:
macos
test now install S4 as welltest-optics
now skipped for windowsnumpy
TESTED WHEELS:
LINK to wheels
Know issues:
meson.build
fileflake8
does not support nativelypyproject.toml
Solution; use a aliasFlake8-pyproject
TODO (after consensus):
setup.cfg
mypy.ini
to be integrated inpyproject.toml
windows
andmacos - arm64
test_examples
does not work onwindows