qpv-research-group / solcore5

A multi-scale, python-based library for the modelling of solar cells and semiconductor materials
https://www.solcore.solar/
Other
133 stars 77 forks source link

[ENH] Move to meson build system #242

Closed Abelarm closed 1 year ago

Abelarm commented 1 year ago

This PR refer to the issue #238 ad it changes the build system from numpy.distutils to meson.

command to build:

python -m devpy build -- -Dwith_pdd=true -Dinstall_test=true

with_pdd=true: if to build the pdd install_test=true: if to copy the test directory

Major changes:

Minor changes:

TESTED WHEELS:

LINK to wheels


Know issues:


TODO (after consensus):

codecov[bot] commented 1 year ago

Codecov Report

Merging #242 (2034eb5) into develop (d5ab3bd) will increase coverage by 10.95%. The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop     #242       +/-   ##
============================================
+ Coverage    46.15%   57.10%   +10.95%     
============================================
  Files           85      103       +18     
  Lines         9124    11615     +2491     
============================================
+ Hits          4211     6633     +2422     
- Misses        4913     4982       +69     
Impacted Files Coverage Δ
solcore/tests/test_light_source.py 100.00% <0.00%> (ø)
solcore/tests/test_dielectric_constant.py 100.00% <0.00%> (ø)
solcore/tests/test_tmm_core_vec.py 100.00% <0.00%> (ø)
solcore/tests/test_solar_cell_solver.py 100.00% <0.00%> (ø)
solcore/tests/test_registries.py 89.70% <0.00%> (ø)
solcore/tests/test_structure.py 100.00% <0.00%> (ø)
solcore/tests/conftest.py 92.66% <0.00%> (ø)
solcore/tests/test_optics.py 100.00% <0.00%> (ø)
solcore/tests/mock_ddModel.py 100.00% <0.00%> (ø)
solcore/tests/test_state.py 100.00% <0.00%> (ø)
... and 13 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

phoebe-p commented 1 year ago

Hi both, sorry I missed the review request for this PR. I will quickly check tomorrow when I have my Windows laptop if the Windows wheel also works and then merge!

Edit: it works :) this is great!!!