search

qpv-research-group / solcore5

A multi-scale, python-based library for the modelling of solar cells and semiconductor materials
https://www.solcore.solar/
Other
133 stars 77 forks source link

PDD and SPECTRAL2 fixes #273

Closed phoebe-p closed 7 months ago

phoebe-p commented 7 months ago

Fixes #266 (thanks to Fortran code fixes by @sbhasan) and also fixes and issue in the spectral2.py file, where the "urban" AOD model, or c and d coefficients passed as lists by the user, could not be set due to a typo and incorrect type checking.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 84.12698% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 60.23%. Comparing base (b3310ca) to head (88755cd).

Files Patch % Lines
solcore/light_source/spectral2.py 80.43% 9 Missing :warning:
solcore/sesame_drift_diffusion/solve_pdd.py 92.30% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #273 +/- ## =========================================== + Coverage 59.46% 60.23% +0.76% =========================================== Files 108 108 Lines 12341 12361 +20 =========================================== + Hits 7339 7446 +107 + Misses 5002 4915 -87 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.