At least tolerate url in href attributes for svg use-tags - Githubissues

qq15725 / modern-screenshot

📸 Quickly generate image from DOM node using HTML5 canvas and SVG

https://toolpkg.com/html-to-image

MIT License

504 stars 36 forks source link

At least tolerate url in href attributes for svg use-tags #44

Closed strindhaug closed 1 year ago

strindhaug commented 1 year ago

Description

Added tests and partial fix (prevents javascript crash) for https://github.com/qq15725/modern-screenshot/issues/43

TODO figure out how to support external svg's in use href tag (if at all possible).

Additional context

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[ ] Read the Pull Request Guidelines and follow the PR Title Convention.
[ ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
modern-screenshot	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 28, 2023 2:02pm