I figured out a way to fetch and embed the external svg-files so that both local and external references work.
Everything seems to work when I run the tests, and I'm pretty sure I'm only modifying cloned elements.
I changed the test a bit to to check that it behaves correctly with regards to preferring "href" over "xlink:href" too.
What is the purpose of this pull request?
[x] Bug fix
[x] New Feature
[ ] Documentation update
[ ] Other
Before submitting the PR, please make sure you do the following
Description
A complete fix for https://github.com/qq15725/modern-screenshot/issues/43
I figured out a way to fetch and embed the external svg-files so that both local and external references work. Everything seems to work when I run the tests, and I'm pretty sure I'm only modifying cloned elements.
I changed the test a bit to to check that it behaves correctly with regards to preferring "href" over "xlink:href" too.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).