fix: when bgImage eq to none, still drawImageCount - Githubissues

qq15725 / modern-screenshot

📸 Quickly generate image from DOM node using HTML5 canvas and SVG

https://toolpkg.com/html-to-image

MIT License

588 stars 38 forks source link

fix: when bgImage eq to none, still drawImageCount #55

Closed welkinwong closed 11 months ago

welkinwong commented 11 months ago

Description

when embed style include background-image and value equal to none, context.drawImageCount will be ++, that slow in safari.

about style declaration:

background-image: none;
border-image-source: none;
-webkit-border-image: none;
-webkit-mask-image: none;
list-style-image: none;

What is the purpose of this pull request?

[X] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[X] Read the Pull Request Guidelines and follow the PR Title Convention.
[X] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[X] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
modern-screenshot	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 24, 2023 7:12pm