search

qq99 / echoplexus

Socket.io powered chat, JavaScript REPL, whiteboard, and WebRTC calls
Other
394 stars 53 forks source link

irc-proxy : hide /msg Nickserv identify message #232

Closed alx closed 10 years ago

alx commented 10 years ago

I've seen it twice since people are beginning to use echoplexus irc-proxy, they try to identify their user and the identify command is broadcasted in clear for everybody.

Would it be possible to hide this message ? or implement /msg command ?

qq99 commented 10 years ago

Oh shit, I didn't think of that!

I could swear /msg was implemented. I'm very sorry to you and your users!!

Looks like it should be working using the echoplexus command /whisper /tell https://github.com/qq99/echoplexus/blob/irc-proxy/src/server/IrcProxyServer.coffee#L182

I'll have to investigate why it's not -- looks like any non-command should be suppressed from being sent

I'm on vacation now for my wedding, so it might be a while

qq99 commented 10 years ago

Is it possible they typed /msg nickserv .... with `in front? We should probably try to trim the start of messages of whitespace if the first non-whitespace character is/`

qq99 commented 10 years ago

Any chance you have more info on the exact string they tried to enter (minus their password)? I don't think this should have occurred unless they put non-whitespace in front of their /msg nickserv identify _____

alx commented 10 years ago

true, tried on my side and couldn't reproduce this bug