search

qqrz997 / CustomSabersLite

A beat saber plugin to replace default sabers with custom sabers.
GNU General Public License v3.0
15 stars 0 forks source link

A glowing line appears at the end of the trail #28

Open rynan4818 opened 3 days ago

rynan4818 commented 3 days ago

When using a specific Saber model, a glowing line appears at the end of the trail.

Saber models

https://modelsaber.com/Sabers/?id=1558510617&pc

Tested with BeatSaber 1.38.0 and CustomSabersLite 0.12.7

image

SaberFactory for BeatSaber 1.29.1 displays correctly as shown.

image

qqrz997 commented 3 days ago

this is an issue with the saber

SaberFactory has a setting that clamps the texture on a custom trail, this has caused a long, hidden problem. CustomSabersLite will not have any settings to correct mistakes made by saber creators so that they will create sabers for longevity.

since SaberFactory has been around for most of the game's lifespan, a large quantity of sabers were created and tested with specific settings in SaberFactory. this is bad design on SaberFactory's part, as it means that not every saber is properly configured by default.

it may become possible in a future version of CustomSabersLite to customize your saber with another saber's custom trail. i am hoping that will minimize this problem, whilst not covering up improper configuration of sabers.

rynan4818 commented 3 days ago

I see! I understand.

https://mdotamaan.github.io/BeatSaber-CustomTrailsGuide/#Trail%20Material

So the reason is that the Wrap Mode is set to Repeat instead of Clamp in Setting Up The Trail Material.

The model I'm actually using is a private one, so I'd like to try either modifying the original model or making a mod to forcibly set Texture.wrapMode to Clamp.

rynan4818 commented 3 days ago

I created a mod that applies a patch and confirmed that the problem was solved.

https://github.com/rynan4818/CustomSabersLiteTextureWrapClampPatch

If possible, I would like to consider modifying the original model.