qqzsxyz / vimwiki

Automatically exported from code.google.com/p/vimwiki
0 stars 0 forks source link

Links to other wikies are highlighted as non-existed #308

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. add link [[wiki1:index]] to your wiki0

What is the expected output? What do you see instead?
It should be highlighted as existed no matter what maxhi is set to.

Original issue reported on code.google.com by habamax on 10 May 2012 at 5:36

GoogleCodeExporter commented 8 years ago
Stuart, in the code I can see that [[wikiN:...]] designed to be highlighted as 
existent and non-existent, but they are always non-existent.

Should we fix it that way?

Original comment by habamax on 10 May 2012 at 3:34

GoogleCodeExporter commented 8 years ago
I agree that they should not be non-existent.  The two other options are:

1. Highlight all of them as existent
2. Scan the filesystem to identify existent versus non-existent

I would go with option 1 for simplicity, however, Tomas would also be a good 
person to consult, since he has invested significant effort into the current 
highlighting code ...

Original comment by stu.andrews on 10 May 2012 at 11:18

GoogleCodeExporter commented 8 years ago

Original comment by habamax on 13 May 2012 at 3:35

GoogleCodeExporter commented 8 years ago
Hmm, [[wiki0:NonExistentPage]] is highlighted ... 

But, the code is simpler now.  

Original comment by stu.andrews on 14 May 2012 at 4:22

GoogleCodeExporter commented 8 years ago
Are you sure? 

In my environment with maxhi=1 [[wiki0:NonExistentPage]] is highlighted as 
existent link.

Original comment by habamax on 14 May 2012 at 4:36

GoogleCodeExporter commented 8 years ago
I have also tried it on windows, and it is ok there too...

Original comment by habamax on 14 May 2012 at 1:34

GoogleCodeExporter commented 8 years ago
I expected that when wikiN was active, [[wikiN:NonExistentPage]] would not be 
highlighted since it does not exist!

We are agreed about [[wikiN:NonExistentPage]] being highlighted when wikiN is 
**not active**.  I guess the question I was raising is whether or not 
conditional highlighting should be applied for [[wikiN:...]] when wikiN **is 
active**.

This usage is not common, so I would be happy to keep the current behavior, 
perhaps with a note in the docs/code.

Thoughts?

Original comment by stu.andrews on 14 May 2012 at 1:59

GoogleCodeExporter commented 8 years ago
I think we shouldn't bother with highlighting current 'wikiN:' links.
Let us keep current behaviour.

Original comment by habamax on 14 May 2012 at 2:08