Closed ramfox closed 5 years ago
I feel good about the pr in terms of the issues that is addresses. I've been dogfooding and seeing other bugs/issues, but out of the scope of what I was initially trying to address.
I say we merge and I'll start new prs for bugs that arise, especially since it will feel like forward momentum.
perf. Let's do it!
closes #425 closes #421
fromRegistry
adjustments in DatasetHeaderedit: after talking with Brendan, going to remove the new registry section of entities, and have all the datasets live in one place. So much nicer.
Here are the other things that this pr covers:
[x] check for profile photo bug
Walking back some network additions:
[x] remove registry schemas
[x] remove registry section from entities
[x] update selectors to pull from the correct section
[x] double check actions for any needed changes
[x] remove /network/ route
[x] remove RegistryDatasetContainer & any references
[x] remove anything that links to /network/ route
[x] add isRegistryDataset(path) selector
[x] isLocalDataset should check the local pagination ids and if the hash exists in this location, then it is local
[x] add isLocal var to dataset and dataset container
[x] add fromRegistry var to dataset and dataset container
[x] add datasetLinks function that determines the links to pass to the navLinks page (using datasetRef, fromRegistry, and isLocal)
[x] add buttonFunctions function that determines with functions to pass to the buttonGroup (using isLocal, fromRegistry, isPublished, and isLatestDataset)