ramfox
commented
5 years ago hi! The idea of adding keyboard shortcuts is super cool!
This is definitely something that needs thinking out before we put it into effect, as once a person is familiar with a set of default shortcuts it's hard to train them to change.
It's also compounded by the fact that we have both a webapp and an electron app. When using the webapp, we are accessing Qri through a browser that has its own keyboard short cuts, which is the discrepancy you are getting now. Ctrl-s when you are using a browser means "Save this webpage"
So, do we override browser shortcuts, even though it might subvert peoples expectations? Or do we only allow keyboard shortcuts using the electron app? Needs more thought, but its definitely something that should find its way into the app down the line.
Platform How were you accessing the qri frontend?
Version What version of the Qri frontend are you using? 8.0.0
Describe the bug A clear and concise description of what the bug is.
Whenever I hit control S it tries to save the webpage instead of the code I'm working on
To Reproduce Steps to reproduce the behavior:
Expected behavior For the code to save
Screenshots If applicable, add screenshots to help explain your problem.
Additional context Add any other context about the problem here.