qri-io / data-stories-scripts

A collection of scripts used for data logging in support of _Data Stories_ on qri.io.
28 stars 15 forks source link

Data Story: California State Parks Data #6

Open feep opened 4 years ago

feep commented 4 years ago

Three stories:

Generate and use dataset

Improve dataset

Validate with schema.json

feep commented 4 years ago

Blockers

2.

3.

feep commented 4 years ago

We can cut the validation bit, and I can publish the dataset to a new user if you want the story to go asap.

feep commented 4 years ago

structure.json bit deferred to a separate story, so we can post this.

Especially since @Arqu is working on jsonschema.

https://github.com/qri-io/jsonschema/pull/63 and future PRs.

Arqu commented 4 years ago

Oh, just to add to this, think you should definitely proceed with this and "unblock" yourself for the time being by doing what Holger did and you can refer to this for a bit more input.

In a nutshell, for the problematic onces you should do an anyOf with your current validation rules + type [string, null] to account for the None/Null values. A bit of fiddling should get you to a spot that works. It's not pretty, but should get you over the hump. The jsonschema work will take a while to land, especially the part with nullables.

feep commented 4 years ago

Right, I got the working JSON from Holger.

=]

Thanks, Holger.

Anyway still deferring structure.json for other reasons.

Will write later. Maybe with new "AllowNullable" Maybe without.