search

qri-io / desktop

Qri Desktop
https://qri.io/desktop
GNU General Public License v3.0
67 stars 14 forks source link

User can update Profile #64

Closed chriswhong closed 5 years ago

chriswhong commented 5 years ago

User can update their profile. Use the same implementation as in qri desktop.

image

b5 commented 5 years ago

I think we should do this on qri cloud, especially if we're going to do hosted profile photos

dustmop commented 5 years ago

An extra wrinkle on this: it's possible currently to rename your peer on the command-line, either by using qri config set peername ..., or by editing your config.yaml. However, ds_refs stores dataset information, and some commands will fail if they see a profile name that doesn't match the profileID. Basically, we should be treating profileIDs as authoritative, and the peername as just presentation, but not all of our codebase does this. Some of this logic is handled by CanonicalizePeername and CanonicalizeDatasetRef, but since these are considered accessors, neither of these will write updated peernames back to ds_refs. Not sure how to architect it, but something in our stack should be detecting peername changes and writing them back to ds_refs.

chriswhong commented 5 years ago

Closing, profile updates happen in Qri Cloud