all of the runs that do not result in a commit are showing this strange "zero" time that comes from the empty commitTime. We should instead be relying on the runStart + runDuration
(In the backend, the CommitTime field is a golang time.Time type, not a pointer to a time.Time. Since it is not a pointer, the empty value results in "0001-01-01T00:00:00Z", when stringified. If it were a pointer, the value in golang would be nil, and then the value would be dropped when converted to json & sent over the the frontend. Since it is NOT nil, the value is read & stringified, resulting in these strange dates on the frontend. We may want to consider converting the CommitTime field from time.Time to *time.Time)
ramfox
commented
3 years ago
all of the runs that do not result in a commit are showing this strange "zero" time that comes from the empty
commitTime. We should instead be relying on therunStart+runDuration(In the backend, the
CommitTimefield is a golangtime.Timetype, not a pointer to atime.Time. Since it is not a pointer, the empty value results in "0001-01-01T00:00:00Z", when stringified. If it were a pointer, the value in golang would benil, and then the value would be dropped when converted to json & sent over the the frontend. Since it is NOT nil, the value is read & stringified, resulting in these strange dates on the frontend. We may want to consider converting theCommitTimefield fromtime.Timeto*time.Time)