Closed boandriy closed 2 years ago
I pushed a commit with some major refactoring:
DatasetHeader
into two components: DatasetHeader
, which contains all of the selectors and actions used when rendering the Header for the active dataset and DatasetHeaderRender
which is a simplified rendering component.DatasetHeaderRender
has some improvements to the dataset name and title. Now they are always text inputs that change their styles when editable/focused. This prevents the shift we were seeing when editing these values. Also added styles to make them match the mockups/color scheme.DatasetHeaderRender
is then used by ManualDatasetCreation
to allow for editing of the name and title.When the user selects a file to upload:
Note For now I have removed the ability to edit a dataset's title from the header on a dataset the user owns. I have kept all of the UI and logic for this in DatasetNameCommitModal
which is unused, but we can bring this back if we need it. I think what we will probably want here is to just bring the user to the dataset editor UI if they want to edit the meta.title.
To get this PR across the finish line:
IconButton
as a child of DatasetHeaderRender
to allow the user to cancel creating a new dataset. This should just navigate to the previous route (it's essentially a back button)
added manual dataset creation UI