search

qri-io / frontend

frontend application for our qri.cloud site
GNU General Public License v3.0
3 stars 2 forks source link

feat: extending e2e tests to clean after themselves #594

Closed boandriy closed 2 years ago

boandriy commented 2 years ago

extending e2e tests to clean after themselves deleting the created datasets

closes #319

ramfox commented 2 years ago

cool, the dataset clean up looks good!

I just have questions about the username/password & creating a new account.

Is there a plan for how we are going to get to the point of being able to remove a user all in the e2e tests?

Also, it doesn't look like we use the USERNAME or PASSWORD global vars any longer, we should remove those & the check to ensure that they are set environment variables.

boandriy commented 2 years ago

cool, the dataset clean up looks good!

I just have questions about the username/password & creating a new account.

Is there a plan for how we are going to get to the point of being able to remove a user all in the e2e tests?

Also, it doesn't look like we use the USERNAME or PASSWORD global vars any longer, we should remove those & the check to ensure that they are set environment variables.

I talked with @Arqu , about cleaning the users. And we decided that this will be done on the BE, as there are few issues with giving an access to just delete a user. Yep, will clean the Unused global vars.

Arqu commented 2 years ago

Yep, the above is correct. User deletion will be done manually every now and then (will make a cron if it becomes tedious) simply based off of the prefix for the user.