qri-io / frontend

frontend application for our qri.cloud site
GNU General Public License v3.0
3 stars 2 forks source link

fix: react-helmet titles not appearing #607

Closed chriswhong closed 2 years ago

chriswhong commented 2 years ago

Fixes a regressing from #603. react-helmet doesn't like react fragments as children, and was causing the frontend to crash in development. The production build worked, but the titles and other HEAD things that react-helmet was supposed to be assigning were not assigned.

There will need to be some follow-on work to get the correct meta tags to show up when doing server side rendering, but we can tackle that later.