search

qri-io / frontend

frontend application for our qri.cloud site
GNU General Public License v3.0
3 stars 2 forks source link

feat: run queue #608

Open boandriy opened 2 years ago

boandriy commented 2 years ago

added run queue, both on the collection and run now page. closes #537

ramfox commented 2 years ago

Hey, so examining your PR and taking a look at the backend.

I think the way you are adding the "Waiting" event is a clever way to solve this. But it means that we lose the ability to "cancel" the queued run, because you need the RunID in order to cancel the event. So I took a look at what we were sending over the websocket:

{ 
    // this is the run id
    data: "6ea4d6e2-e145-44e3-b8f2-a8c7988140a9"
    // this is ALSO the run id
    sessionID: "6ea4d6e2-e145-44e3-b8f2-a8c7988140a9"
    ts: 1639068512035200300
    type: "automation:RunQueuePush"
}

This is NOT ENOUGH INFO!!! How are you supposed to relate that run id to the dataset? I keep failing to think of the practical way this is going to be used in the frontend.

So, I'm going to refactor the backend to send over the dataset id (InitID) as well. Let's have a quick meeting tomorrow where we talk about the best way this can work for you in frontend.