qri-io / frontend

frontend application for our qri.cloud site
GNU General Public License v3.0
3 stars 2 forks source link

refactor: eliminate unnecessary calls to /ds/get #659

Closed chriswhong closed 2 years ago

chriswhong commented 2 years ago

Closes #266

We had api calls spread across DatasetRoutes, DatasetWrapper, and DatasetPreviewPage, resulting in 3 separate calls to the same endpoint (/ds/get) when a preview route was loaded.

chriswhong commented 2 years ago

I pushed a commit which:

This way, we have everything only fetching data when it needs to:

I think #3 you mentioned above is a separate issue, we should make sure preview is updated after a commit.