search

qri-io / qri

you're invited to a data party!
https://qri.io
GNU General Public License v3.0
1.11k stars 66 forks source link

bug(remove): remove hanging when removing a dataset not in my namespace #1055

Closed ramfox closed 4 years ago

ramfox commented 4 years ago

This bug only occurs when the Qri daemon is running.

The remove command hangs when the api is on and you try to remove a dataset from another user's namespace.

dustmop commented 4 years ago

This is happening because base.RemoveNVersionsFromStore fails to look up dataset versions that don't exist locally, it just hangs trying to fetch them from IPFS. When not connected, these lookups fail fast instead.

Fix incoming.

Relatedly, when we qri add someone's dataset, currently logbooks are not being fetched:

> qri add b5/world_bank_population
⠒ 16:28:09.264 ERROR        lib: pulling logs: decoding public key: proto: required field "Type" not set datasets.go:831
dustmop commented 4 years ago

Fixed by #1059.