search

qri-io / qri

you're invited to a data party!
https://qri.io
GNU General Public License v3.0
1.11k stars 66 forks source link

Consider moving qri-io/dataset/detect to mainline repo #1371

Open dustmop opened 4 years ago

dustmop commented 4 years ago

The code in https://github.com/qri-io/dataset/tree/master/detect is used to detect schemas for datasets that don't have them, including types and column names, amongst some other things. We've recently starting doing these sorts of "intelligent inference" tasks more over in the mainline qri repo (for example: dsref/generate), and personally I feel like that's a good thing: perhaps the dataset repo should be less fancy, more pure data representation, and leave opinionated stances to other packages.

Moving detect into qri would allow us to use dsref/generated instead of varName, which would enable us to fix https://github.com/qri-io/desktop/issues/508. It would also make it easier to fix https://github.com/qri-io/qri/issues/1322 and other such problems.

dustmop commented 4 years ago

Making this change would also make it easier to implement this suggestion: https://github.com/qri-io/qri/issues/1536.