search

qri-io / qri

you're invited to a data party!
https://qri.io
GNU General Public License v3.0
1.11k stars 66 forks source link

No changes to save after changes to structure.json #1505

Open hbruch opened 4 years ago

hbruch commented 4 years ago

Environment

MacOs,

What version of qri are you using (qri version)?

Qri cli 0.9.11

Issue

What did you do?

I changed some field descriptions/formats in structure.json. qri save only detected changes after a qri status was executed:

$ qri save -m "fix first_seen_hour description"
for linked dataset [mfdz/stuttgart_gelbekarten]

no changes to save
$ qri status
for linked dataset [mfdz/stuttgart_gelbekarten]

  modified: structure (source: structure.json)

run `qri save` to commit this dataset
$qri save -m "fix first_seen_hour description"
for linked dataset [mfdz/stuttgart_gelbekarten]

dataset saved: mfdz/stuttgart_gelbekarten@/ipfs/QmYmQWGwzyanxBfCqPTdNvqsmDvmrREPTNak7Eq1PpuLto

Further, I expected the commit to receive my supplied update message. Instead, a generic, not too helpful deduced commit message overwrote my supplied message.

dustmop commented 4 years ago

Somewhat speculating here, but the "no changes to save" problem is likely not related to running qri status, but rather a result of deepdiff containing non-determinism: https://github.com/qri-io/deepdiff/pull/7

The -m flag being ignored, however, does seem like a bug. Having trouble reproducing it. What is the output of qri log me/stuttgart_gelbekarten?