search

qri-io / qri

you're invited to a data party!
https://qri.io
GNU General Public License v3.0
1.11k stars 66 forks source link

refactor(workflow): replace datasetID with initID #1854

Closed Arqu closed 3 years ago

Arqu commented 3 years ago

Depends on https://github.com/qri-io/qri/pull/1852

ramfox commented 3 years ago

This looks good, in that I can't see any problems. But I don't understand the need for the change. Does DatasetID mean something different than InitID? The only place I see us talking about InitID is in logbook, in dataset we just call it ID, so it made sense to me to call it DatasetID. To me, having InitID on the workflow struct might seem like there may be a workflow InitID.

Arqu commented 3 years ago

Refs contain InitIDs and they're ubiquitous by now. It doesn't do anything other than making things consistent.