Add methods to profile.ID called Encode and Validate. Encode replaces the old String function, and base58 encodes an ID. The old String function now outputs wrapped hex, to make it clear that profile.IDs have different shape from base58 encoded strings. The Validate method ensures that a profile.ID is not double-encoded. Use this function in collection.Set to prevent callers from breaking their collection by passing invalid IDs.
Fixes #1857
This refactoring was performed by renaming the old profile.ID.String method (to Stringz) then fixing all of the compilation errors this caused. This renaming uncovered that the function CompareDatasetRef was relying on the implicit base58 encoding that fmt.Errorf performs.
Add methods to profile.ID called Encode and Validate. Encode replaces the old String function, and base58 encodes an ID. The old String function now outputs wrapped hex, to make it clear that profile.IDs have different shape from base58 encoded strings. The Validate method ensures that a profile.ID is not double-encoded. Use this function in collection.Set to prevent callers from breaking their collection by passing invalid IDs.
Fixes #1857
This refactoring was performed by renaming the old
profile.ID.Stringmethod (toStringz) then fixing all of the compilation errors this caused. This renaming uncovered that the functionCompareDatasetRefwas relying on the implicit base58 encoding thatfmt.Errorfperforms.