qri-io / qri

you're invited to a data party!
https://qri.io
GNU General Public License v3.0
1.11k stars 66 forks source link

fix(lib): fix deploy if a ds has no changes #1873

Closed ramfox closed 3 years ago

ramfox commented 3 years ago

1) fix time comparison, should be using time.Equal rather than == 2) When a dataset has no changes, the lib.Save command returns a nil dataset. However, we are still relying on the dataset to provide us with an init id. On top of that, the dataset sent over to us by the user does not need to have an init id in order for the deploy request to go through, so we are not guaranteed that the submitted dataset will have what we need. In order to ensure we have an init id, we must resolve the reference.