qri-io / qri

you're invited to a data party!
https://qri.io
GNU General Public License v3.0
1.11k stars 66 forks source link

refactor(transform): Single dataset, move conflict check up to lib.Save #1888

Closed dustmop closed 3 years ago

dustmop commented 3 years ago

Instead of a pair of read/write datasets on the starlark ds object, have only a single dataset. For checking conflicts, have Apply track which components are modified by a transform script. Compare that result against the components provided to the save path, but do so in a much more obvious way, up in lib/

dustmop commented 3 years ago

Ok, now switched to using PathMap to get the components that exist in the incoming dataset. Switched the changeSet (previously changeList) to use full component names now, which removes the need for the shortNameToComponent function.