Save path should utilize ds.Commit.ID, ds.Name, and ds.Peername instead of a ref - Githubissues

qri-io / qri

you're invited to a data party!

https://qri.io

GNU General Public License v3.0

1.1k stars 66 forks source link

Save path should utilize ds.Commit.ID, ds.Name, and ds.Peername instead of a ref #1913

Open b5 opened 2 years ago

b5 commented 2 years ago

we've run into this most recently in https://github.com/qri-io/qri/pull/1911, and have known about this issue for a while. We could clean up TODOs like this one: https://github.com/qri-io/qri/blob/d451f6f8a2b247958e80fdd14c79cfc0d4e6b1f2/base/save.go#L133-L135

Now that we have the collection subsystem to manage references independent of the save path