search

qri-io / qri

you're invited to a data party!
https://qri.io
GNU General Public License v3.0
1.1k stars 66 forks source link

fix(run): run store deserialization updated #1922

Closed Arqu closed 2 years ago

Arqu commented 2 years ago

@ramfox This made a lot of issues in parsing the runs from the run store and introduces some follow up behavior issues. The only gotcha is that we have to make sure all the payloads do actually conform to the event.TransformMessage payload type which I'm still not a 100% on as it's a bit hard to track down.

Arqu commented 2 years ago

@b5 sorry, bad wording on my end. What I mean is that the handler for the specific payload used to accept a plain string, and now I've forced it to be an event.TransformMessage. It's hard to find all the places we send those to make sure we don't send any more strings. But yes, all of this is contained strictly to the event.ETTransformPrint, event.ETTransformError events so damage is scoped. I can make it more resilient by trying to deserialize either tho, but would rather enforce the correct default behavior.

Think I got it all covered now tho.