search

qri-io / qri

you're invited to a data party!
https://qri.io
GNU General Public License v3.0
1.1k stars 66 forks source link

fix(dataframe): Clone schema, correct jsonschema types. Fixes tests. #1942

Closed dustmop closed 2 years ago

dustmop commented 2 years ago

Unit tests at head have been failing. For some reason, column types were wrong, which lead to different stringification of many values. By fixing types, these tests pass again. For an unknown reason, the schema needs to be cloned as well. This should only be a temporary measure, because we should instead understand why the old construction method doesn't work.

dustmop commented 2 years ago

Depends on https://github.com/qri-io/starlib/pull/140