search

qri-io / qri_install

easy qri building & installation
1 stars 0 forks source link

fix(qri_build/qri): adjustments to `GOCACHE` so that my machine can build the qri binary #2

Closed ramfox closed 5 years ago

ramfox commented 5 years ago

Need GOCACHE to be set in order to build the qri binary! fixes #1

also adds patterns to ignore in the gitignore file

And also adds a missing readOnly param in the webapp build section.

ramfox commented 5 years ago

@b5 So we have one BuildWebapp func that takes a readOnly param, and a BuildWebappReadonly that assumes we are building a Read Only version of the webapp. Should I remove BuildWebappReadonly in favor of the BuildWebapp func?

Edit: spoke to b5, I'm removing BuildWebappReadonly